Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.16](backport #4599) Clean up APM getting started intro page #4688

Merged
merged 1 commit into from
Dec 13, 2024
Merged

[8.16](backport #4599) Clean up APM getting started intro page #4688

merged 1 commit into from
Dec 13, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 13, 2024

Description

Cleans up the APM getting started intro page as discussed in #4336 including:

  • Which option is the "easiest": @simitt @bmorelli25 what do you think about just removing the note at the top and letting users determine which is the easiest method for their situation? If we can't say that one is easier than the other without explaining the context, then I'm not sure it makes sense to have a note at the top.
  • What's preventing feature parity: I moved this note to the part of the table that discusses supported outputs.
  • Required components: I rephrased the Elastic Agent list item (I was going to use a footnote but I was having trouble using it inside a list that's inside a table).
  • I also deleted a big block of commented out content since we can get it from the git history if needed, but let me know if you think we should keep it.

Documentation sets edited in this PR

Check all that apply.

  • Stateful (docs/en/observability/*)
  • Serverless (docs/en/serverless/*)
  • Integrations Developer Guide (docs/en/integrations/*)
  • None of the above

Related issue

Closes #4336

Checklist

  • Product/Engineering Review
  • Writer Review

Follow-up tasks

Select one.

  • This PR does not need to be ported to another doc set because:
    • The concepts in this PR only apply to one doc set (serverless or stateful)
    • The PR contains edits to both doc sets (serverless and stateful)
  • This PR needs to be ported to another doc set:
    • Port to stateful docs: <link to PR or tracking issue>
    • Port to serverless docs: <link to PR or tracking issue>
This is an automatic backport of pull request #4599 done by [Mergify](https://mergify.com).

@colleenmcginnis @mergify
Clean up APM getting started intro page (#4599)
050797f 
* clean up apm getting started intro page

* Update docs/en/observability/apm/getting-started-apm/index.asciidoc

(cherry picked from commit 494830b)
@mergify mergify bot added the backport label Dec 13, 2024
@mergify mergify bot requested a review from a team as a code owner December 13, 2024 15:40
@github-actions GitHub Actions
Copy link
Contributor

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@colleenmcginnis colleenmcginnis enabled auto-merge (squash) December 13, 2024 15:52
@colleenmcginnis colleenmcginnis merged commit a8656d5 into 8.16 Dec 13, 2024
8 checks passed
@colleenmcginnis colleenmcginnis deleted the mergify/bp/8.16/pr-4599 branch December 13, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colleenmcginnis colleenmcginnis colleenmcginnis approved these changes

Assignees

@colleenmcginnis colleenmcginnis

Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@colleenmcginnis